Skip to content

feat: add support for skip-repo, repo-include, repo-exclude to print command#589

Merged
lindell merged 3 commits intolindell:masterfrom
pascal-hofmann:master
Nov 16, 2025
Merged

feat: add support for skip-repo, repo-include, repo-exclude to print command#589
lindell merged 3 commits intolindell:masterfrom
pascal-hofmann:master

Conversation

@pascal-hofmann
Copy link
Copy Markdown
Contributor

@pascal-hofmann pascal-hofmann commented Nov 12, 2025

What does this change

feat: add support for skip-repo, repo-include, repo-exclude to print command.

What issue does it fix

Closes #588.

Checklist

  • Made sure the PR follows the CONTRIBUTING.md guidelines
  • Tests if something new is added

@pascal-hofmann pascal-hofmann force-pushed the master branch 2 times, most recently from 2c7a379 to cd39e0d Compare November 12, 2025 11:02
@pascal-hofmann pascal-hofmann marked this pull request as ready for review November 12, 2025 11:32
Copy link
Copy Markdown
Owner

@lindell lindell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The code looks good. But I know realized that I should probably not have accepted the original PR to add this to the run command as is. If you want to merge this as is that is fine, but this should be refactored to:

  1. Move these three flags into its own function. Probably its own file. Similar to configurePlatform.
  2. Add a new struct RepoFilters in the multigitter package
  3. Add a parse function to get the RepoFilters struct from the cmd package.
  4. Change filterRepositories to take this struct

@lindell
Copy link
Copy Markdown
Owner

lindell commented Nov 13, 2025

Asked an agent to make these changes from the comment above. After some minor tweaks. The commit pushed is the result. Please take a look.

@pascal-hofmann
Copy link
Copy Markdown
Contributor Author

I reviewed the changes. LGTM!

@lindell lindell merged commit 8e2c150 into lindell:master Nov 16, 2025
9 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Included in release v0.60.0 🎉

lindell added a commit that referenced this pull request Nov 23, 2025
lindell added a commit that referenced this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Support skip-repo, repo-include and repo-exclude for multi-gitter print

2 participants