Add short to extension check#7076
Merged
Pothulapati merged 1 commit intolinkerd:mainfrom Oct 14, 2021
Merged
Conversation
Contributor
|
@sankalp-r Thanks for raising the PR. It works well with the viz extension. Can you also do the same for |
4cb6037 to
e95f12c
Compare
Signed-off-by: Sankalp Rangare <[email protected]>
e95f12c to
12ac4e8
Compare
Contributor
Author
I have done the same changes for |
adleong
pushed a commit
that referenced
this pull request
Oct 22, 2021
Fixes #7032 This PR adds the support for `-oshort` flag for the `viz`, `multicluster` and `jaeger` extensions which used to fail previously with an invalid error. Signed-off-by: Sankalp Rangare <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7032
Signed-off-by: Sankalp Rangare [email protected]