Merged
Conversation
Recent theme updates change how images are sized inside guides and docs, and on the home page/listing pages Eventually, we shoud run hugo -gc to clean up the old generated images that are no longer used. But out of caution I thought we should delay this, in case some users' browsers still request them
Contributor
Author
|
✔️ Deploy preview for nostalgic-ptolemy-b01ab8 ready! 🔨 Explore the source changes: 9d1cf97 🔍 Inspect the deploy logs: https://app.netlify.com/sites/nostalgic-ptolemy-b01ab8/deploys/5fdccc50045c01000736951a 😎 Browse the preview: https://deploy-preview-3857--nostalgic-ptolemy-b01ab8.netlify.app |
d18bc1b to
bda388b
Compare
andystevensname
approved these changes
Dec 18, 2020
nmelehan
commented
Dec 20, 2020
go.mod
Outdated
| github.com/bep/hugo-jslibs/instantpage v0.0.0-20200822093604-7b6e0aaba587 // indirect | ||
| github.com/bep/hugo-jslibs/turbolinks v0.1.2 // indirect | ||
| github.com/bep/linodedocs v0.0.0-20201218014640-53ad752e0ac9 | ||
| github.com/bep/linodedocs v0.0.0-20201220215401-da781bf59b68 |
Contributor
Author
There was a problem hiding this comment.
this brings the PR up to date with the latest changes to the linode-website-partials repo from last friday: https://github.com/linode/linode-website-partials/commits/master
- Updates AlpineJS - Fixes a search timing issue Bjørn discovered - Makes clicking on a title in the ToC update the browser's URL with the title's ID
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theme updates:
<meta name="keywords">: https://github.com/bep/linodedocs/pull/48Note that the Netlify preview for this will be missing thumbnails for images in the Guides carousel on the home page, because the production Algolia index has not been updated with them.
To see a working version of that feature in this branch, you'll need to test it locally with our instructions for using a personal testing Algolia.
Release checklist:
Before merging to main:
ordinalto the Retrieved Attributes of these staging indices (Update: @nmelehan has done this)linode-documentation-main-preview-nginxlinode-documentation-sorted-main-preview-nginxlinode-documentation-develop-preview-nginxlinode-documentation-sorted-develop-preview-nginxBefore cutting the hotfix release:
ordinalto the Retrieved Attributes of these production indices (Update: @nmelehan has done this)linode-documentationlinode-documentation-sortedShortly after cutting the release:
If you'd like to run Google's Lighthouse test to measure the performance update, here's instructions: https://developers.google.com/web/tools/lighthouse