Skip to content

fix: dpkg find copyright#302

Open
bmsuseluda wants to merge 3 commits intolinuxdeploy:masterfrom
bmsuseluda:fix/dpkgFindCopyright
Open

fix: dpkg find copyright#302
bmsuseluda wants to merge 3 commits intolinuxdeploy:masterfrom
bmsuseluda:fix/dpkgFindCopyright

Conversation

@bmsuseluda
Copy link

@bmsuseluda bmsuseluda commented Dec 13, 2024

Hello together,

after experiencing similar things as described in #270 i found out, that dpkg-query does not reliably find something by an absolute path. Therefore i only use the filename from the canonicalized path which should result in finding more copyright files.

i hope my changes are fine in the way i did them.
Please let me know if there is something i need to change.

thank you

@bmsuseluda
Copy link
Author

@TheAssassin Is there something i can do to bring this further?

@TheAssassin
Copy link
Member

This potentially copies many unrelated files into the AppDir. I don't see an improvement in this approach.

@bmsuseluda
Copy link
Author

bmsuseluda commented Feb 14, 2025

Without it linuxdeploy throws about 100 warnings in my build, that copyright files can not be found. You can see it here: https://github.com/bmsuseluda/ares-emu-appimage/actions/runs/13240659936/job/36955122575#step:8:954

And this is because of the absolute path that is used right now. I looked on the system and dpkg can find the copyright files, but not reliably with this absolute path. With just the filename dpkg finds the correct copyright as you can see here: https://github.com/bmsuseluda/ares-emu-appimage/actions/runs/13161636934/job/36731614392#step:8:1

The filesize between these 2 is nearly the same, so i do not see a problem with unrelated files.
Please let me know if i overlook something here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants