This repository was archived by the owner on Aug 31, 2021. It is now read-only.
resolved issue 8884 - the properties don't return all properties and imp...#22
Closed
montegoulding wants to merge 11 commits intolivecode:release-6.0.1from
Closed
resolved issue 8884 - the properties don't return all properties and imp...#22montegoulding wants to merge 11 commits intolivecode:release-6.0.1from
montegoulding wants to merge 11 commits intolivecode:release-6.0.1from
Conversation
…implemented a few changes to the array. Additionally changed from colours and patterns list to individual elements so it's easier to work with the array. Changed to return unicode variants where they double up so no data is lost in native formats. Added resizeQuality, paintCompression, stack filename, externals. The array is now multi-dimensional where properties are themselves arrays. Finally, added the optional 'effective' adjective to the properties.
Contributor
|
Since you were looking to do some more work on this, I'll leave it for now... Seems like a good candidate for the development branch (and thus next non-maintenance release) when its ready :) |
added 8 commits
April 19, 2013 21:21
getting properties added fullscreen, editMenus, shadowOffset, systemWindow, layerMode, padding. removed some read only properties paintCompression, size Changed properties array setter to set rect and style first to ensure they are set before other properties that might change as a result of them.. for example, setting the rect after the gradient changes the gradient. The style seems to change other properties like the textAlign of buttons which possibly needs to be investigated.
…ion. removed session only button visited
…t isn't overridden
…o ensure left, top etc are applied correctly
…e props only if hasunicode(). Also removed card rect as read only.
…onverted to native if possible using MCExecPoint::trytoconvertutf16tonative
Contributor
There was a problem hiding this comment.
I don't believe there's any need to copy the string here - store_element() doesn't take ownership. You can just use the const strings. (Same is true with all assignements to t_token).
Contributor
|
Hi Monte, Sorry for taking a while to get back to looking at this - last week was a bit busy after getting back from holiday! Anyway, I've taken another look and made a couple of comments on the code... It looks almost ready to go :) Thanks, Mark. |
…move string comparisons
Contributor
|
Hi Monte I've just pulled this in as branch 'feature-revised_properties_prop' and merged that into 'develop'. Thanks! Mark. |
trevordevore
pushed a commit
to trevordevore/livecode
that referenced
this pull request
Jul 7, 2015
docs: Initial draft of Builder style guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...lemented a few changes to the array.
Additionally changed from colours and patterns list to individual elements so it's easier to work with the array. Changed to return unicode variants where they double up so no data is lost in native formats. Added resizeQuality, paintCompression, stack filename, externals. The array is now multi-dimensional where properties are themselves arrays. Finally, added the optional 'effective' adjective to the properties.
Sending the pull request against release-6.0.1 for simplicity but don't really expect it to be looked at until after release as there could be some (albeit minor considering the low level of use of the property) backwards compatibility concerns in this one. I think most users of
the propertieswould be quite keen on the changes.