This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bugfix 15878 ]] Fix a crash caused by waiting during modal session setup#2980
Closed
livecodefraser wants to merge 1 commit intolivecode:develop-7.0from
Closed
[[ Bugfix 15878 ]] Fix a crash caused by waiting during modal session setup#2980livecodefraser wants to merge 1 commit intolivecode:develop-7.0from
livecodefraser wants to merge 1 commit intolivecode:develop-7.0from
Conversation
… setup Creating a modal window session on Cocoa can trigger event processing (e.g. because another window lost focus). Waiting during these events caused a crash because the wait loop attempted to run the modal session that hadn't actually been created yet.
Contributor
|
@livecodefraser, I'm afraid that this is a 6.7-introduced bug... Can you rebase your fix? |
Contributor
Author
|
Hmm... according to @trevordevore, the crash only happens in 7. It might be a combination of changes that brought about these exact circumstances. |
Contributor
Author
|
Moved to 6.7: #2981 |
Contributor
|
@livecodefraser FWIW I have been shipping my app with the 6.7 engine for over a year and I've never seen the crash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a modal window session on Cocoa can trigger event processing
(e.g. because another window lost focus). Waiting during these
events caused a crash because the wait loop attempted to run the
modal session that hadn't actually been created yet.