Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Fixes the dbsqlite gyp file for building on linux#7127

Closed
mwieder wants to merge 25 commits intolivecode:develop-9.5from
mwieder:fix_building_dbsqlite_on_linux
Closed

Fixes the dbsqlite gyp file for building on linux#7127
mwieder wants to merge 25 commits intolivecode:develop-9.5from
mwieder:fix_building_dbsqlite_on_linux

Conversation

@mwieder
Copy link
Copy Markdown
Contributor

@mwieder mwieder commented Jul 23, 2019

Fixes the dbsqlite gyp file for building on linux. Or more properly to avoid crashing on launch after building from source. This fix was proposed by @livecodefraser and it solves the problem for me.

Or more properly to avoid crashing on launch after building from source
@mwieder
Copy link
Copy Markdown
Contributor Author

mwieder commented Jul 23, 2019

From my limited understanding of this, it would appear that the team's build server is using a gcc version pre-5.1? I'm currently on 7.4.0. And that this patch instructs the compiler that the dbsqlite libraries are in C++03 ABI rather than C++11?

@mwieder
Copy link
Copy Markdown
Contributor Author

mwieder commented Aug 8, 2019

Should I resubmit this against develop-9.5 instead?

@livecodepanos
Copy link
Copy Markdown
Contributor

Oh I missed this PR! Nice, so this was the reason LC crashed for me when I built from source on Linux recently!

Thanks @mwieder and @livecodefraser :)

@livecodepanos livecodepanos changed the base branch from develop to develop-9.5 August 8, 2019 18:22
@livecodepanos
Copy link
Copy Markdown
Contributor

@mwieder I have rebased this against develop-9.5, luckily develop and develop-9.5 have not diverged yet, so I was able to change the base from the GitHub web interface without conflicts

livecodepanos and others added 15 commits August 13, 2019 11:43
[Bugfix-22278] Correct missing text in log documentation
@mwieder
Copy link
Copy Markdown
Contributor Author

mwieder commented Oct 1, 2019

Am I really the only one attempting to build from source on a linux distro that hasn't already reached its end of life? I have to apply this patch every time I build, and then try to remember to remove it afterwards.

@mwieder mwieder closed this by deleting the head repository Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants