Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[[ Bug 22256 ]] Use correct user info key to obtain keyboard size#7155

Merged
livecodepanos merged 1 commit intolivecode:develop-9.5from
montegoulding:bugfix-22256
Sep 13, 2019
Merged

[[ Bug 22256 ]] Use correct user info key to obtain keyboard size#7155
livecodepanos merged 1 commit intolivecode:develop-9.5from
montegoulding:bugfix-22256

Conversation

@montegoulding
Copy link
Copy Markdown
Contributor

This patch changes our use of UIKeyboardFrameBeginUserInfoKey which is the
keyboard frame prior to animating into place to UIKeyboardFrameEndUserInfoKey
which is the final keyboard frame. This resolves a bug where the height of the
keyboard changes during the animation.

This patch changes our use of `UIKeyboardFrameBeginUserInfoKey` which is the
keyboard frame prior to animating into place to `UIKeyboardFrameEndUserInfoKey`
which is the final keyboard frame. This resolves a bug where the height of the
keyboard changes during the animation.
@montegoulding montegoulding added this to the 9.5.1-rc-1 milestone Sep 3, 2019
@montegoulding montegoulding self-assigned this Sep 3, 2019
@livecodeali
Copy link
Copy Markdown
Member

@livecode-vulcan review ok c713ffd

@livecode-vulcan
Copy link
Copy Markdown
Contributor

💙 review by @livecodeali ok c713ffd

livecode-vulcan added a commit that referenced this pull request Sep 13, 2019
[[ Bug 22256 ]] Use correct user info key to obtain keyboard size

This patch changes our use of `UIKeyboardFrameBeginUserInfoKey` which is the
keyboard frame prior to animating into place to `UIKeyboardFrameEndUserInfoKey`
which is the final keyboard frame. This resolves a bug where the height of the
keyboard changes during the animation.
@livecode-vulcan
Copy link
Copy Markdown
Contributor

😎 test success c713ffd

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-ndk16r15: success
  • try-community-arm64-android-ndk16r15: success
  • try-community-x86-android-ndk16r15: success
  • try-community-x86_64-android-ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos12.1: success
  • try-community-universal-ios-iphonesimulator12.1: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos merged commit 5e28e82 into livecode:develop-9.5 Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants