Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[Bugfix-19377] Edit version comparison example to work beyond LC 9#7170

Merged
livecodepanos merged 3 commits intolivecode:develop-9.5from
livecodealice:bugfix-19377
Sep 26, 2019
Merged

[Bugfix-19377] Edit version comparison example to work beyond LC 9#7170
livecodepanos merged 3 commits intolivecode:develop-9.5from
livecodealice:bugfix-19377

Conversation

@livecodealice
Copy link
Copy Markdown

Changed the version comparison example to be numeric rather than alphabetical, provided the format of the output remains the same.

Comment thread docs/notes/bugfix-19377.md Outdated
@@ -0,0 +1 @@
# Changed an example in the version entry to not operate on alphabetical comparison.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest something more generic, e.g. Updated example in version dictionary entry

@livecodepanos
Copy link
Copy Markdown
Contributor

@livecode-vulcan review ok be64c73

@livecode-vulcan
Copy link
Copy Markdown
Contributor

💙 review by @livecodepanos ok be64c73

livecode-vulcan added a commit that referenced this pull request Sep 26, 2019
[Bugfix-19377] Edit version comparison example to work beyond LC 9

Changed the version comparison example to be numeric rather than alphabetical, provided the format of the output remains the same.
@livecode-vulcan
Copy link
Copy Markdown
Contributor

😞 test failure be64c73

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-ndk16r15: failure
  • try-community-arm64-android-ndk16r15: failure
  • try-community-x86-android-ndk16r15: failure
  • try-community-x86_64-android-ndk16r15: failure
  • try-community-js-emscripten-sdk1.35: failure
  • try-community-universal-ios-iphoneos13.1: pending
  • try-community-universal-ios-iphonesimulator13.1: pending
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: failure
  • try-community-x86_64-linux-debian8: failure
  • try-community-x86-win32: pending
  • try-community-x86_64-win32: pending

@livecodepanos
Copy link
Copy Markdown
Contributor

@livecode-vulcan retry be64c73

livecode-vulcan added a commit that referenced this pull request Sep 26, 2019
[Bugfix-19377] Edit version comparison example to work beyond LC 9

Changed the version comparison example to be numeric rather than alphabetical, provided the format of the output remains the same.
@livecode-vulcan
Copy link
Copy Markdown
Contributor

😎 test success be64c73

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-ndk16r15: success
  • try-community-arm64-android-ndk16r15: success
  • try-community-x86-android-ndk16r15: success
  • try-community-x86_64-android-ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos13.1: success
  • try-community-universal-ios-iphonesimulator13.1: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos merged commit f2e6b48 into livecode:develop-9.5 Sep 26, 2019
@livecodepanos livecodepanos added this to the 9.5.1-rc-1 milestone Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants