Add featureinfo nested field for reporting feature specific metadata#1367
Merged
Add featureinfo nested field for reporting feature specific metadata#1367
Conversation
🦋 Changeset detectedLatest commit: 6633ead The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
davidzhao
reviewed
Jan 15, 2026
| // this allows reporting only periods during which a feature is active. | ||
| repeated TimeRange time_ranges = 8; | ||
|
|
||
| optional FeatureInfo feature_info = 9; |
Member
There was a problem hiding this comment.
while keeping the enum types is more technically "correct".. my concern is this increases the number of updates that needs to go out whenever a new model is added.. or another feature changes. I would vote for keeping this as a generic map<string, string> field, where any feature attributes/metadata could be stored without requiring a full update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to report ai-coustics model usage for billing reasons, I've introduced a new
feature_infonested field within theFeatureUsageInfowhich contains an enum mapping to the currently in use ai-coustics model. The thinking of keeping this generic was that it could be extended for other future feature specific metadata for other models in the future, but I'm open to altering this if others think this is a bit too preemptive.