Conversation
🦋 Changeset detectedLatest commit: 387aa64 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
Updated the changeset to include a patch for '@livekit/protocol' and normalize protobuf 'id' log field names.
| string room_name = 6; | ||
| string participant_id = 7; | ||
| string track_id = 8; | ||
| string participant_id = 7 [(logger.name) = "participantID"]; |
There was a problem hiding this comment.
Would have been nice to call this pID as that is what is used everywhere, but will look odd here.
There was a problem hiding this comment.
we could do this but this is going to go into customer facing logs. maybe we should abandon the old convention in the interest of clarity? it's easy to change if you'd prefer pID
There was a problem hiding this comment.
No, I think clarity is more important. I think we should move other logs to this, but that could take a while
There was a problem hiding this comment.
nah, i did this in about 5 minutes with claude... i think we can change it everywhere without much more effort. i'll submit a pr after i land this
No description provided.