Merged
Conversation
juliagallucci
suggested changes
May 6, 2024
juliagallucci
left a comment
There was a problem hiding this comment.
Part A is well-executed, but Part B must take into account this additional parameter is_case_sensitive. As is, code executes with errors - Please revise and resubmit
lizsyeo
commented
May 6, 2024
Owner
Author
lizsyeo
left a comment
There was a problem hiding this comment.
updated pt 2 of the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I created a function to test if two words are anagrams.
What did you learn from the changes you have made?
I learnt how to write functions and test them.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No, my approach was to sort the words and if they are the same, then they are anagrams (assuming not case sensitive).
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes, I had to convert the words to lower case when comparing them for the 1st part of the assignment.
How were these changes tested?
I tested them using the sample words given in the assignment.
A reference to a related issue in your repository (if applicable)
NA.
@mentions of the person or team responsible for reviewing proposed changes (At least 2 people)
Checklist