Open
Conversation
juliagallucci
approved these changes
May 7, 2024
juliagallucci
left a comment
There was a problem hiding this comment.
Great! Your code executes well without error. Some suggestions for improvement would be to remove redundant lines (ie conditional statements already return a boolean true/false, so no need to come this)-- also, your output should be True/False rather than a string. Lastly, be sure to comment your code for improved clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added code to the file.
What did you learn from the changes you have made?
I have learnt how to use sortI() function in python.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I think that is the easiest way to do my assignment.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes. I am not able to sync my change to github. I learn how to use git push command and overcome it.
How were these changes tested?
I tested in vs code and compare with the example output.
A reference to a related issue in your repository (if applicable)
Checklist