Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

Serializer should works for Arrays#17

Merged
lluzak merged 1 commit intomasterfrom
serialized-array
Dec 5, 2014
Merged

Serializer should works for Arrays#17
lluzak merged 1 commit intomasterfrom
serialized-array

Conversation

@LTe
Copy link
Copy Markdown
Collaborator

@LTe LTe commented Dec 5, 2014

When we want to serialize multiple forms we need to recognize situation
that value of object is kind of Array. Then execute for each elements
serialized_attributes.

Comment thread spec/serializer_spec.rb Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use be_truthy

When we want to serialize multiple forms we need to recognize situation
that value of object is kind of Array. Then execute for each elements
`serialized_attributes`.
@LTe LTe force-pushed the serialized-array branch from 34ca954 to 7714465 Compare December 5, 2014 12:24
@LTe
Copy link
Copy Markdown
Collaborator Author

LTe commented Dec 5, 2014

@lluzak updated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we usually use params from rails. And this object is kind of HashWithIndifferentAccess. So when we converted this params we returned simple Hash. What is a little strange.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, makes sense

lluzak added a commit that referenced this pull request Dec 5, 2014
Serializer should works for Arrays
@lluzak lluzak merged commit c63083e into master Dec 5, 2014
@lluzak lluzak deleted the serialized-array branch December 5, 2014 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants