Fix super invocations for onnx and tflite backends#30
Merged
mbeissinger merged 1 commit intolobe:masterfrom Nov 29, 2021
stevecheckoway:fix-super
Merged
Fix super invocations for onnx and tflite backends#30mbeissinger merged 1 commit intolobe:masterfrom stevecheckoway:fix-super
mbeissinger merged 1 commit intolobe:masterfrom
stevecheckoway:fix-super
Conversation
The `super()` calls are using the wrong class name. By doing this, they're skipping the `__init__()` for the actual super class. This breaks calling `predict()` because `self.lock` has not been assigned. The change for the `tflite` backend has been tested. The change for `onnx` has not been tested, but seems correct.
mbeissinger
approved these changes
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
super()calls are using the wrong class name. By doing this,they're skipping the
__init__()for the actual super class.This breaks calling
predict()becauseself.lockhas not beenassigned.
The change for the
tflitebackend has been tested. The change foronnxhas not been tested, but seems correct.