Fixing some inconsistencies across different backends.#2
Merged
slime73 merged 3 commits intolove2d:mainfrom Dec 15, 2021
Merged
Fixing some inconsistencies across different backends.#2slime73 merged 3 commits intolove2d:mainfrom
slime73 merged 3 commits intolove2d:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1 to match cURL backend, at least some parts of it. None of these applies to NSURL backend as I don't have mac to test!
The only notable difference is cURL backend returns 0 for invalid schema whilst the others returns nil followed by the error message.