progress on option to post entries for multiple accounting years#9
Draft
modellurgist wants to merge 5 commits intoloyning:masterfrom
Draft
progress on option to post entries for multiple accounting years#9modellurgist wants to merge 5 commits intoloyning:masterfrom
modellurgist wants to merge 5 commits intoloyning:masterfrom
Conversation
…tries of each invoice into multiple year-specific bundles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not yet recommended to merge.
During tests an undocumented error (
Office24Seven.Library.Economy.Accounting.AttachmentIsPostedException- Attachment is posted in the journal) was returned by 24/7 API that suggests different accounting years must be handled via separate stamp numbers (i.e. uploaded Attachments).This can already be accomplished using the existing library by performing a duplicate upload (and acquiring its stamp number) for each year and performing separate ledger post requests.
It's possible that more information about the error or a change in 24/7 API constraints could allow this PR with its single-stamp-number / multiple bundle approach to succeed, after some further modification.
Here is a description of the current work and the limitation above:
a "bundlelist" of "bundles" and their "vouchers" can only refer to just one attachment (not documented but encountered this error:
Office24Seven.Library.Economy.Accounting.AttachmentIsPostedException- Attachment is posted in the journal)