Merged
Conversation
|
You did a good job here! Also, please keep in mind that the PR should be open until it's marked. Please go ahead and do the modification and then let me know, Thanks! |
Owner
Author
|
Hi Pedram,
Apologies for the late response - This message was in my spam folder and I
have been sick all week so didn't even see it! I made the requested changes
and I'm pretty sure I left the pull request open this time. I'm not sure
how/why I closed it last time but please let me know if I did it correctly
this time!
Thank you,
Lauren
…On Thu, Dec 5, 2024 at 9:21 PM Pedram ***@***.***> wrote:
You did a good job here!
Just a quick note:
There is a small issue with the sorting logic in your function in part 2.
You are passing the strings 'word_a' and 'word_b' (the literal string
names) to the sorted() function, instead of passing the variables word_a
and word_b.
Also, please keep in mind that the PR should be open until it's marked.
Please go ahead and do the modification and then let me know, Thanks!
—
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BM74UVAUOUXM7WUMV4WDLGL2EEX5NAVCNFSM6AAAAABS2X2FT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRSGE3DOOBUGQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Defined anagram checker functions, one that does not account for case sensitivity and one that does
What did you learn from the changes you have made?
Learned how to define a function and how to use an IF function
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
There were no other approaches
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
My biggest challenge with this assignment was actually pushing my changes back to Git - just not used to the process yet.
How were these changes tested?
All code was tested against provided code
A reference to a related issue in your repository (if applicable)
Checklist