Skip to content

Add sequence field to trades #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neilgarb merged 1 commit into from
Mar 25, 2019
Merged

Add sequence field to trades #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion luno_python/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
VERSION = '0.0.3'
VERSION = '0.0.4'
22 changes: 19 additions & 3 deletions luno_python/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,11 +429,12 @@ def list_transactions(self, id, max_row, min_row):
}
return self.do('GET', '/api/1/accounts/{id}/transactions', req=req, auth=True)

def list_user_trades(self, pair, limit=None, since=None):
def list_user_trades(self, pair, after_seq=None, before=None, before_seq=None, limit=None, since=None, sort_desc=None):
"""Makes a call to GET /api/1/listtrades.

Returns a list of your recent trades for a given pair, sorted by oldest
first.
first. If <code>before</code> is specified, then the trades are returned
sorted by most-recent first.

<code>type</code> in the response indicates the type of order that you placed
in order to participate in the trade. Possible types: <code>BID</code>,
Expand All @@ -448,15 +449,30 @@ def list_user_trades(self, pair, limit=None, since=None):

:param pair: Filter to trades of this currency pair.
:type pair: str
:param after_seq: Filter to trades from (including) this sequence number.
Default behaviour is not to include this filter.
:type after_seq: int
:param before: Filter to trades before this timestamp.
:type before: int
:param before_seq: Filter to trades before (excluding) this sequence number.
Default behaviour is not to include this filter.
:type before_seq: int
:param limit: Limit to this number of trades (default 100).
:type limit: int
:param since: Filter to trades on or after this timestamp.
:type since: int
:param sort_desc: If set to true, sorts trades in descending order, otherwise ascending
order will be assumed.
:type sort_desc: bool
"""
req = {
'pair': pair,
'after_seq': after_seq,
'before': before,
'before_seq': before_seq,
'limit': limit,
'since': since,
'sort_desc': sort_desc,
}
return self.do('GET', '/api/1/listtrades', req=req, auth=True)

Expand Down Expand Up @@ -570,7 +586,7 @@ def send(self, address, amount, currency, description=None, message=None):
If the email address is not associated with an existing Luno account, an
invitation to create an account and claim the funds will be sent.

Warning! Digital currency transactions are irreversible. Please ensure your
Warning! Cryptocurrency transactions are irreversible. Please ensure your
program has been thoroughly tested before using this call.

Permissions required: <code>Perm_W_Send</code>
Expand Down