Conversation
iverhun
approved these changes
Aug 14, 2017
flylight
reviewed
Aug 16, 2017
|
|
||
| @RestController | ||
| @RequestMapping(path = "/dsl") | ||
| public class DslController { |
Collaborator
There was a problem hiding this comment.
Why DSL ? We have some specific domain for this script, right? Then lets make this controller represents actual meaning.
|
|
||
| DelegatingScript delegatingScript = (DelegatingScript) groovy.parse(script); | ||
| delegatingScript.setDelegate(dsl); | ||
| delegatingScript.run(); |
Collaborator
There was a problem hiding this comment.
Here is too much logic as for Controller. Lets create a service layer and move all logic into that class. Lets use controller only as communication layer
| private RatingServiceClient ratingServiceClient; | ||
|
|
||
| @GetMapping(path = "/{scriptName}") | ||
| public Object runScript(@PathVariable(name = "scriptName") String scriptName) throws IOException { |
Collaborator
There was a problem hiding this comment.
Should this have @responsebody annotation or no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.