Skip to content

Re-upload clean full version of assignment 1#4

Open
lyuxiaotian wants to merge 1 commit intomainfrom
assignment-1-new
Open

Re-upload clean full version of assignment 1#4
lyuxiaotian wants to merge 1 commit intomainfrom
assignment-1-new

Conversation

@lyuxiaotian
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I already confused by so many branch and mistake i made

What did you learn from the changes you have made?

but gradually understand the basic logic behind

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! One note for improvement, you don’t need to explicitly return True or False since the comparison itself already evaluates to a Boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants