Add docklib 1.2.0 to "recommended" and "opinionated" flavors#15
Merged
erikng merged 1 commit intomacadmins:mainfrom Oct 16, 2020
homebysix:docklib
Merged
Add docklib 1.2.0 to "recommended" and "opinionated" flavors#15erikng merged 1 commit intomacadmins:mainfrom homebysix:docklib
erikng merged 1 commit intomacadmins:mainfrom
homebysix:docklib
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've recently published docklib to PyPi so that it can be installed via
pip. Therefore, it seems like a good candidate for inclusion in the Python packages produced by this project.I'm open to convincing about whether docklib belongs in "recommended" or just in "opinionated," but I think the former given how MacAdmin-specific docklib is and how many people use docklib with outset.
The changes submitted here produced the desired effect for me (a pkg was produced that included docklib among its installed modules, and interactively running
from docklib import Dockworked successfully in the managed Python REPL).