Conversation
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=========================================
+ Coverage 56.29% 56.5% +0.21%
=========================================
Files 24 25 +1
Lines 4036 4111 +75
=========================================
+ Hits 2272 2323 +51
- Misses 1520 1543 +23
- Partials 244 245 +1
Continue to review full report at Codecov.
|
i4ki
requested changes
May 3, 2017
| } | ||
|
|
||
| cmd.SetStdin(shell.stdin) | ||
| cmd.SetStderr(shell.stderr) |
Collaborator
There was a problem hiding this comment.
As I'd said to you in person today, we can set stdout here also, but set it to nil before calling cmd.StdoutPipe in executePipe.
Member
Author
There was a problem hiding this comment.
Yes, will do that soon.
| } | ||
|
|
||
| func TestExecutePipe(t *testing.T) { | ||
| var stderr bytes.Buffer |
Collaborator
There was a problem hiding this comment.
what's the problem with the table tests?
Collaborator
There was a problem hiding this comment.
ooh, because of the races we discussed in the other PR, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is kind of shitty for now. But it fixes the problem.
The tests had to be refactored because of race conditions, but I don't know if it's the right solution.
Also, I had to leave the
SetStdoutcall inexecuteCommandbecausecmd.StdoutPipe()is already setting Stdout 😞. Any ideas?Fixes #210