Prevent @hey.com addresses from being suggested to be in error#180
Open
dhh wants to merge 1 commit intomailcheck:masterfrom
dhh:patch-1
Open
Prevent @hey.com addresses from being suggested to be in error#180dhh wants to merge 1 commit intomailcheck:masterfrom dhh:patch-1
dhh wants to merge 1 commit intomailcheck:masterfrom
dhh:patch-1
Conversation
Right now mailcheck will suggest that someone entering "[email protected]" really meant "[email protected]".
slavingia
approved these changes
Jul 3, 2020
Marcisbee
approved these changes
Jul 7, 2020
benaubin
approved these changes
Aug 3, 2020
vinibrsl
approved these changes
Aug 15, 2020
|
looks like this is approved, is this module maintained anymore? |
|
Can we please have this PR merged since it is an urgent concern. The domain @hey.com is widely used now. |
|
Hey @dhh @kelly-tock @adisamicheal, this library is no longer maintained, and it sucks... I rewrote it entirely, added HEY and many more domains, and update it for 2022 and onward: https://github.com/ZooTools/email-spell-checker Let me know your thoughts! :)
Link: https://github.com/ZooTools/email-spell-checker Come check it out and give it a ⭐️ for the effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now mailcheck will suggest that someone entering "[email protected]" really meant "[email protected]".