Add missing device attribute to Navigation events#565
Merged
Guardiola31337 merged 1 commit intomasterfrom Sep 19, 2017
Merged
Conversation
e839cf5 to
1b31830
Compare
ericrwolfe
reviewed
Sep 19, 2017
| } | ||
|
|
||
| private void addGeneralNavigationMetadataTo(Hashtable<String, Object> eventWithAttributes) { | ||
| eventWithAttributes.put(MapboxEvent.KEY_MODEL, Build.MODEL); |
There was a problem hiding this comment.
The nav telemetry spec expects a device attribute rather than model. It looks like this was an inconsistency/oversight when the spec was defined.
1b31830 to
f5733f3
Compare
Contributor
Author
|
@ericrwolfe ready for a second 👀 |
ericrwolfe
approved these changes
Sep 19, 2017
f5733f3 to
709f0b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deviceattribute to Navigation events👀 @cammace @ericrwolfe @zugaldia