Omit null optional fields in Nav events#566
Merged
Guardiola31337 merged 2 commits intomasterfrom Sep 19, 2017
Merged
Conversation
ericrwolfe
suggested changes
Sep 19, 2017
ericrwolfe
left a comment
There was a problem hiding this comment.
Thanks for all of these fixes!
Is there a way to do this without simply omitting "null" values?
The cancel event, for example, requires an arrivalTimestamp, which takes a null json literal (as opposed to a "null" string value) if the timestamp hasn't been set yet.
Contributor
Author
|
@ericrwolfe f4925a3 addressed your comments. Ready for a second 👀 |
ericrwolfe
approved these changes
Sep 19, 2017
637d028 to
e9f66f4
Compare
added 2 commits
September 19, 2017 23:59
…nal fields over sending nulls
e9f66f4 to
f4925a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
originalRequestIdentifier,requestIdentifierandaudioTypeused inNavigationMetricsWrapper(Nav SDK) may be"null"so this PR:originalRequestIdentifier,requestIdentifierandaudioTypeoptional fields (when"null") over sendingnulls👀 @cammace @ericrwolfe @zugaldia