Skip to content

Fix missing device attribute for navigation events #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Guardiola31337 merged 1 commit into from
Sep 21, 2017
Merged

Fix missing device attribute for navigation events #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...libandroid-telemetry/src/main/java/com/mapbox/services/android/telemetry/MapboxEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public class MapboxEvent implements Serializable {
public static final String KEY_USER_ID = "userId";
public static final String KEY_ENABLED_TELEMETRY = "enabled.telemetry";
public static final String KEY_MODEL = "model";
public static final String KEY_DEVICE = "device";
public static final String KEY_OPERATING_SYSTEM = "operatingSystem";
public static final String KEY_RESOLUTION = "resolution";
public static final String KEY_ACCESSIBILITY_FONT_SCALE = "accessibilityFontScale";
Expand Down
2 changes: 1 addition & 1 deletion ...ndroid-telemetry/src/main/java/com/mapbox/services/android/telemetry/MapboxTelemetry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ private boolean isANavigationEvent(String eventType) {
}

private void addGeneralNavigationMetadataTo(Hashtable<String, Object> eventWithAttributes) {
eventWithAttributes.put(MapboxEvent.KEY_DEVICE, Build.MODEL);
eventWithAttributes.put(MapboxNavigationEvent.KEY_DEVICE, Build.MODEL);
eventWithAttributes.put(MapboxNavigationEvent.KEY_VOLUME_LEVEL, TelemetryUtils.getVolumeLevel(context));
eventWithAttributes.put(MapboxNavigationEvent.KEY_SCREEN_BRIGHTNESS, TelemetryUtils.getScreenBrightness(context));
eventWithAttributes.put(MapboxNavigationEvent.KEY_APPLICATION_STATE, TelemetryUtils.getApplicationState(context));
Expand Down
1 change: 1 addition & 0 deletions ...d-telemetry/src/main/java/com/mapbox/services/android/telemetry/http/TelemetryClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ private void sendEventsWrapped(Vector<Hashtable<String, Object>> events, Callbac
jsonObject.putOpt(MapboxNavigationEvent.KEY_ESTIMATED_DURATION,
evt.get(MapboxNavigationEvent.KEY_ESTIMATED_DURATION));
jsonObject.putOpt(MapboxNavigationEvent.KEY_REROUTE_COUNT, evt.get(MapboxNavigationEvent.KEY_REROUTE_COUNT));
jsonObject.putOpt(MapboxNavigationEvent.KEY_DEVICE, evt.get(MapboxNavigationEvent.KEY_DEVICE));
jsonObject.putOpt(MapboxNavigationEvent.KEY_VOLUME_LEVEL, evt.get(MapboxNavigationEvent.KEY_VOLUME_LEVEL));
jsonObject.putOpt(MapboxNavigationEvent.KEY_SCREEN_BRIGHTNESS,
evt.get(MapboxNavigationEvent.KEY_SCREEN_BRIGHTNESS));
Expand Down
1 change: 1 addition & 0 deletions ...src/main/java/com/mapbox/services/android/telemetry/navigation/MapboxNavigationEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public class MapboxNavigationEvent {
public static final String KEY_ESTIMATED_DISTANCE = "estimatedDistance";
public static final String KEY_ESTIMATED_DURATION = "estimatedDuration";
public static final String KEY_REROUTE_COUNT = "rerouteCount";
public static final String KEY_DEVICE = "device";
public static final String KEY_VOLUME_LEVEL = "volumeLevel";
public static final String KEY_SCREEN_BRIGHTNESS = "screenBrightness";
public static final String KEY_APPLICATION_STATE = "applicationState";
Expand Down