Conversation
|
|
||
| HashMap<String, Object> map = new HashMap<>(); | ||
| // Potentially null values | ||
| map.put(ALTITUDE, location.hasAltitude() ? location.getAltitude() : JsonToken.NULL); |
Contributor
There was a problem hiding this comment.
Why JsonToken.NULL instead of JSONObject.NULL?
Author
There was a problem hiding this comment.
Because the values null, not the entire object. It doesn't really matter though, they result in the samething.
Contributor
There was a problem hiding this comment.
Wondering why not keeping consistency with the rest of the code then 🤔
| public class NavigationLocation { | ||
|
|
||
| private static final String UTC_TIME_FORMAT = "yyyy-MM-dd'T'HH:mm:ss.SSSZ"; | ||
| private static final String ACCURACY = "horizontalAccuracy"; |
Contributor
There was a problem hiding this comment.
Almost all of these variables are duplicated.
👀 MapboxEvent and MapboxNavigationEvent
Author
There was a problem hiding this comment.
doesn't matter, only temporary. New library should fix this.
zugaldia
approved these changes
Oct 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.