moved toHumanReadableAscii method into library#727
Merged
Conversation
tobrun
approved these changes
Feb 27, 2018
Author
|
commit b1f4a95 only disables checkstyle, not all of circle ci. |
7d69f71 to
3c523ab
Compare
Author
|
The UI tests are failing since we also are using the same internal method in the map SDK, bumping OkHttp back down to 3.9 confirms this. Going ahead and merging to get the fix in the map SDK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In OkHttp 3.10.0,
toHumanReadableAsciiutil method has been moved toOkHttpURLConnectionand marked as private. Since we previously relied on this method, I've ported over the same method into our utils class.