Open
Conversation
kelichiu
reviewed
Feb 2, 2025
kelichiu
left a comment
There was a problem hiding this comment.
Total Point: 64/70
Section 1: 40/46
- Type 1 & Type 2: For Type 2 of customer_address, usually, there will be an additional column that identifies which address is the current one. We can achieve this by adding a is_current column, or other methods. Also, customer_id of Laura shouldn’t be changed when new address comes in.
- For the Date table, it seems like your designed is dedicated to the Sales table. This table should be designed in a way that can be used in combination with all tables that have Date values. You will want to remove the prefix of sales_ in the Date Table
Section 2: 8/8
Section 3: 8/8
Section 4: 8/8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added the responses to assignment 2.md and assignment 2.sql.
What did you learn from the changes you have made?
I learned how to design a logical model from scratch. I also learned how to use coalesce, windowed functions, string manipulations, union, cross-join, insert, delete, and update.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
When I needed to join, I compared the multiple outcomes that I would get with the different types of join options. This made it clearer to me how to use those options in sql.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
While working on long queries I broke it down into steps, so I could keep track of the changes I was making to the tables.
How were these changes tested?
I ran the code multiple times and I also created temporary tables that I considered were necessary to answer the questions.
A reference to a related issue in your repository (if applicable)
Not applicable.
Checklist