Skip to content

Deprecate text.latex.unicode.#11381

Merged
tacaswell merged 2 commits intomatplotlib:masterfrom
anntzer:text.latex.unicode
Jul 9, 2018
Merged

Deprecate text.latex.unicode.#11381
tacaswell merged 2 commits intomatplotlib:masterfrom
anntzer:text.latex.unicode

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Jun 5, 2018

Redo of #11255 (which was reverted in #11345) as the reason for the revert (the test suite being spammed by warnings) went away now that #11292 has been merged.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.0 milestone Jun 5, 2018
@timhoffm
Copy link
Copy Markdown
Member

timhoffm commented Jun 6, 2018 •
edited
Loading

Travis says:

lib/matplotlib/tests/test_rcparams.py::test_rcparams
  /home/travis/build/matplotlib/matplotlib/lib/matplotlib/__init__.py:864: MatplotlibDeprecationWarning: text.latex.unicode is deprecated. Please remove it from your matplotlibrc and/or style files.
    mplDeprecation)
  /home/travis/build/matplotlib/matplotlib/lib/matplotlib/__init__.py:864: MatplotlibDeprecationWarning: text.latex.unicode is deprecated. Please remove it from your matplotlibrc and/or style files.
    mplDeprecation)
  /home/travis/build/matplotlib/matplotlib/lib/matplotlib/__init__.py:864: MatplotlibDeprecationWarning: text.latex.unicode is deprecated. Please remove it from your matplotlibrc and/or style files.
    mplDeprecation)

lib/matplotlib/tests/test_style.py::test_alias[mpl20]
  /home/travis/build/matplotlib/matplotlib/lib/matplotlib/__init__.py:864: MatplotlibDeprecationWarning: text.latex.unicode is deprecated. Please remove it from your matplotlibrc and/or style files.
    mplDeprecation)

Can we get rid of that warning?

@anntzer anntzer force-pushed the text.latex.unicode branch from a76eaba to d3ab158 Compare June 7, 2018 06:52
@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Jun 7, 2018

fixed

@anntzer anntzer force-pushed the text.latex.unicode branch from d3ab158 to 0e611f9 Compare June 19, 2018 23:07
@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Jun 19, 2018

rebased

@tacaswell tacaswell modified the milestones: v3.0, v3.1 Jul 8, 2018
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Jul 8, 2018

Sorry, going back and forth on moving this to 3.1.

Is this a macro that is guaranteed to be in any latex distribution (forgive my ignorance? From the links on #11255 it looks like the answer is yes).

@anntzer This needs a rebase.

tacaswell
tacaswell approved these changes Jul 8, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional on a rebase and confirmation that we expect all reasonable latex installations to have the inputenc package installed.

@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Jul 8, 2018

It's in debian's https://packages.debian.org/stretch/texlive-latex-base and arch's https://www.archlinux.org/packages/extra/any/texlive-core/; seems good enough?

@anntzer
Deprecate text.latex.unicode.
99db86c 
It is 2018 and Python3 is ruling the world; it is high time for usetex
to default to unicode support as well.

(If ``\usepackage[utf8]{inputenc}`` is irremediably breaking some users'
setup we can always revisit this decision.)
@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Jul 8, 2018

rebased

@anntzer anntzer force-pushed the text.latex.unicode branch from 0e611f9 to 0805c57 Compare July 8, 2018 20:12
QuLogic
QuLogic reviewed Jul 8, 2018
View reviewed changes
lib/matplotlib/__init__.py Outdated
'axes.hold': ('2.1',),
'backend.qt4': ('2.2',),
'backend.qt5': ('2.2',),
'text.latex.unicde': ('3.0',),
Copy link
Copy Markdown
Member

@QuLogic QuLogic Jul 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unicode

Copy link
Copy Markdown
Contributor Author

@anntzer anntzer Jul 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, fixed

@anntzer anntzer force-pushed the text.latex.unicode branch from 0805c57 to 70f16f3 Compare July 8, 2018 21:21
@anntzer anntzer force-pushed the text.latex.unicode branch from 70f16f3 to 9a147a4 Compare July 8, 2018 21:33
@tacaswell tacaswell merged commit 6c1105b into matplotlib:master Jul 9, 2018
@anntzer anntzer deleted the text.latex.unicode branch July 10, 2018 09:19
@ImportanceOfBeingErnest ImportanceOfBeingErnest mentioned this pull request May 6, 2019
Closed
This was referenced Jun 18, 2019
Closed
Merged
@tacaswell tacaswell mentioned this pull request Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic left review comments

@tacaswell tacaswell tacaswell approved these changes

@jklymak jklymak jklymak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@anntzer @timhoffm @tacaswell @QuLogic @jklymak