add explanations and examples to the docstring of violinplot#12585
add explanations and examples to the docstring of violinplot#12585andreawwenyi wants to merge 3 commits intomatplotlib:masterfrom andreawwenyi:violinplot_docstring
Conversation
…in the difference between passing an array and passing a sequences of vectors.
story645
left a comment
There was a problem hiding this comment.
Thanks for the PR. I'm thinking you can condense this information a bit into one note.
|
Hi @wywang-nyu, this PR is very welcome and thank you for making it. Do you plan on making the requested changes? |
andreawwenyi
left a comment
There was a problem hiding this comment.
delete this explanation as it is already in the note
Hi, sorry for the delay! I totally forgot about this. I just made the request changes, please review! Thank you. |
| dataset : Array or a sequence of vectors. | ||
| The input data. | ||
| dataset : 2D Array/Matrix or a sequence of vectors. | ||
| The input data. |
There was a problem hiding this comment.
don't need "the input data". Notes about data haven't been moved to notes section"
timhoffm
left a comment
There was a problem hiding this comment.
flake8 complains (see also the flake8 Travis CI build):
./lib/matplotlib/axes/_axes.py:7874:80: E501 line too long (133 > 79 characters)
./lib/matplotlib/axes/_axes.py:7880:26: W291 trailing whitespace
./lib/matplotlib/axes/_axes.py:7881:80: E501 line too long (116 > 79 characters)
./lib/matplotlib/axes/_axes.py:7882:80: E501 line too long (108 > 79 characters)
3 E501 line too long (133 > 79 characters)
1 W291 trailing whitespace
Please fix to comply with our coding conventions.
|
closing because this got kind of addressed in #14107 but will totally reopen if @andrea-w-wang has the bandwidth to readdress this. |
Add explanations and examples to the docstring of violinplot to explain how violinplot handles differently w.r.t. sequence of vectors and 2D array.
Closes #12178
PR Summary
PR Checklist