Skip to content

Backport #13205 on branch v3.0.x (Add xvfb service to travis)#13216

Merged
timhoffm merged 3 commits intomatplotlib:v3.0.xfrom
NelleV:travis_failures_v30x
Jan 19, 2019
Merged

Backport #13205 on branch v3.0.x (Add xvfb service to travis)#13216
timhoffm merged 3 commits intomatplotlib:v3.0.xfrom
NelleV:travis_failures_v30x

Conversation

@NelleV
Copy link
Copy Markdown
Member

@NelleV NelleV commented Jan 18, 2019 •
edited
Loading

PR Summary

Attempt to fix some of our Travis failures on v3.0.x. Supersedes #13206
MarkInfo objects were removed in pytest 4.0. The other solution would be to backport the PR that fixes this from our master branch.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@NelleV NelleV changed the title FIX Starting xvfb as a service to avoid travis failures Backport #13205 on branch v3.0.x (Add xvfb service to travis) Jan 18, 2019
@NelleV NelleV force-pushed the travis_failures_v30x branch from 06e99aa to ae56447 Compare January 18, 2019 05:02
@NelleV NelleV force-pushed the travis_failures_v30x branch from a1ab49b to c129091 Compare January 18, 2019 06:11
@tacaswell tacaswell added this to the v3.0.3 milestone Jan 18, 2019
@tacaswell tacaswell mentioned this pull request Jan 18, 2019
Closed
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Jan 18, 2019

Restarted 3.5 which was the only one that failed and it failed on the Qt tests. I wonder if there is some roll-over going on where we are getting a mixed population of workers, some the new way works and some the oldway works?

@dstansby
Copy link
Copy Markdown
Member

dstansby commented Jan 18, 2019

Yeah, the 3.5 build is getting a xvfb: unrecognized service (https://travis-ci.org/matplotlib/matplotlib/jobs/481215980#L1323)

@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Jan 18, 2019

It is because we force the dist back to trusty, lets see what happens if we drop that....

@tacaswell
CI: do not pull py35 test run back to trusty
dcfe153 
This is to make sure we have the xvfb as a service
@NelleV
Copy link
Copy Markdown
Member Author

NelleV commented Jan 19, 2019

fui! Great! Thanks a lot for fixing that last problem.

@timhoffm timhoffm merged commit 4a63ccb into matplotlib:v3.0.x Jan 19, 2019
timhoffm added a commit that referenced this pull request Jan 19, 2019
@timhoffm
Revert "Backport #13205 on branch v3.0.x (Add xvfb service to travis) (…
d2736de 
…#13216)"

This reverts commit 4a63ccb.
@timhoffm
Copy link
Copy Markdown
Member

timhoffm commented Jan 19, 2019

Hm, maybe I should not have squashed the commits. Should I revert and merge without squashing?

@NelleV
Copy link
Copy Markdown
Member Author

NelleV commented Jan 19, 2019 via email

@NelleV
Copy link
Copy Markdown
Member Author

NelleV commented Jan 19, 2019 via email

@QuLogic
Copy link
Copy Markdown
Member

QuLogic commented Jan 19, 2019

Most of our backports are squashed anyway (all automated ones are.)

@ArchangeGabriel ArchangeGabriel mentioned this pull request Jan 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

topic: testing

Projects

None yet

Milestone

v3.0.3

Development

Successfully merging this pull request may close these issues.

5 participants

@NelleV @tacaswell @dstansby @timhoffm @QuLogic