Skip to content

Backport PR #16112 on branch v2.2.x (CI: Fail when failed to install dependencies)#16137

Merged
tacaswell merged 9 commits intomatplotlib:v2.2.xfrom
Kojoley:auto-backport-of-pr-16112-on-v2.2.x
Jan 20, 2020
Merged

Backport PR #16112 on branch v2.2.x (CI: Fail when failed to install dependencies)#16137
tacaswell merged 9 commits intomatplotlib:v2.2.xfrom
Kojoley:auto-backport-of-pr-16112-on-v2.2.x

Conversation

@Kojoley
Copy link
Copy Markdown
Member

@Kojoley Kojoley commented Jan 7, 2020

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@Kojoley Kojoley added this to the v2.2.5 milestone Jan 7, 2020
@NelleV @Kojoley
Merge pull request matplotlib#16112 from Kojoley/ci-travis-fail-when-…
c1fba63 
…dep-install-fails

CI: Fail when failed to install dependencies
@Kojoley Kojoley force-pushed the auto-backport-of-pr-16112-on-v2.2.x branch from e2f126f to c1fba63 Compare January 9, 2020 15:59
@tacaswell
CI: backport osx on travis changes en-mass
c9e2a06 
This will move testing on travis to python3 (from python2), however I
am not sure it is worth the effort of moving brew on travis back to
python2 so that we can in very short order delete this branch and
close out the 2.2.x series (now that python2 is EOL).
@tacaswell
CI: accept that brew will be verbose
261ae83
@tacaswell
CI: bump sphinx version to pick up support for newer docutils
7b019ec
@tacaswell
CI: remove mac builds on travis
4da7fa1 
The brew configuration has bit-rotted
@tacaswell
CI: remove the nightly build from travis
c85c759
@tacaswell
CI: add py38 to build matrix
a1bf33e
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Jan 19, 2020

I gave up and removed the OSX build and nightly, but added py38 on linux.

@Kojoley
Copy link
Copy Markdown
Member Author

Kojoley commented Jan 19, 2020

I think the OSX problem is in osx_image: xcode7.3 (removing was not backported here)

@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Jan 20, 2020

Tried putting the osx build back and removing the offending line.

@Kojoley I don't want to force-push to your branch without your consent, but one of us should squash this history down to a handful of commits

@Kojoley
Copy link
Copy Markdown
Member Author

Kojoley commented Jan 20, 2020

I don't want to force-push to your branch without your consent

I have no problems with this.

one of us should squash this history down to a handful of commits

Squash and merge button on GitHub is not enough?

@tacaswell tacaswell merged commit 5e13fa9 into matplotlib:v2.2.x Jan 20, 2020
@tacaswell
Copy link
Copy Markdown
Member

tacaswell commented Jan 20, 2020

Fair enough, squashed and merged.

@Kojoley Kojoley deleted the auto-backport-of-pr-16112-on-v2.2.x branch January 20, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.2.5

Development

Successfully merging this pull request may close these issues.

3 participants

@Kojoley @tacaswell @NelleV