Give _DummyAxis instances a __name__#17625
Merged
QuLogic merged 3 commits intomatplotlib:masterfrom Jun 15, 2020
Merged
Conversation
tacaswell
approved these changes
Jun 14, 2020
Member
tacaswell
left a comment
There was a problem hiding this comment.
"both" might be the best option here to avoid playing whack-a-mole.
Member
Author
|
OK, I've added the "both" strategy. I was vacillating originally as to whether to do that. It probably makes sense; users might have their own dummy axis classes. |
anntzer
reviewed
Jun 15, 2020
anntzer
approved these changes
Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
ScalarFormatter.format_data_shortusesself.axis.__name__to determine whether it is working with an x-axis, a y-axis, or something else, presumably a _DummyAxis instance. This was failing in the z-cursor formatting of image-like plots for a the colorbar use case with boundaries specified. This could be solved either by checking first for the presence of the__name__attribute or by giving _DummyAxis instances a name. I chose the latter approach.Closes #17624
PR Checklist