Add Text3D position getter/setter#18525
Merged
dopplershift merged 2 commits intomatplotlib:masterfrom Sep 23, 2020
Merged
Conversation
Member
Author
|
This could maybe do with a What's new entry, but I'd rather finish this sort of change on all the other artists and write one up then (i.e., roll it up into #18189.) |
timhoffm
reviewed
Sep 19, 2020
5cf501e to
e16460f
Compare
timhoffm
approved these changes
Sep 22, 2020
dopplershift
approved these changes
Sep 22, 2020
Contributor
dopplershift
left a comment
There was a problem hiding this comment.
Technically, the change to get_dir_vector's return value is an API change. Do we need a notice for a function so minor?
This avoids saving a second copy of the whole position, and the inconsistencies that might arise thereof.
e16460f to
7034b70
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
And simplify the calculations to avoid the duplicate position.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).