Start testing using GitHub Actions#19036
Merged
tacaswell merged 8 commits intomatplotlib:masterfrom Dec 3, 2020
Merged
Conversation
This is currently Linux-only, and skips caching and code coverage.
This was ignored on Travis for some time.
On Travis, NumPy was already installed and happened to be 1.16.4, roundabout our desired minimum version. On GitHub Actions, NumPy is not installed and gets installed later, since it was never specified in the command with the pins. Also, add minimum Pillow to the pins.
Member
Author
|
Test coverage is up 0.81%, though library coverage is down 5% since the build on #17524? It looks like that drop may be because C code was added back into the count. |
bb8d25a to
36b73cc
Compare
dopplershift
approved these changes
Nov 30, 2020
jklymak
approved these changes
Dec 3, 2020
Member
|
@QuLogic I'm fine with you self-merging this if we don't hear from @tacaswell. Looks good, but I'm not an expert on the testing infrastructure. |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Dec 3, 2020
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Dec 3, 2020
QuLogic
added a commit
that referenced
this pull request
Dec 10, 2020
Backport PR #19036 on branch v3.3.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I don't think we've gotten back any reply from Travis yet. This ports Linux and macOS builds over to GitHub Actions; it takes roughly the same build time overall, though the queue might be shorter. I'm not entirely sure whether I used the right keys for caching or if it's really very effective yet.
I believe interactive backend tests are running though, so this should restore our code coverage results.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).