Enh improve agg chunks error#19343
Merged
QuLogic merged 6 commits intomatplotlib:masterfrom Sep 25, 2021
Merged
Conversation
jklymak
reviewed
Jan 23, 2021
anntzer
reviewed
Jan 23, 2021
anntzer
reviewed
Jan 23, 2021
anntzer
reviewed
Jan 23, 2021
150617a to
6cfa6ed
Compare
c01a41d to
52f7610
Compare
52f7610 to
c19d49f
Compare
c19d49f to
51ae0a8
Compare
anntzer
reviewed
Sep 8, 2021
The error messages now provide better instruction on how to fix the problem. There are some paths we can not split (one with hatching, fills, or that claim they can not be simplified) so tell user that. If we could have otherwise split up the path if the chunksize is set to less than 100, which disables the feature, ask user to make it bigger or make the path simplification more aggressive. If the chunksize is bigger than the data, ask user to make it smaller or make the path simplification more aggressive. If the chunksize is smaller than the data, but still too big ask user to make it smaller or make the path simplification more aggressive. closes matplotlib#19325 Co-authored-by: Antony Lee <[email protected]>
This allows longer, more textured, paths to be drawn with the default settings at the risk of very long run times.
- Make sure values are be big enough / small enough - make long path test more pathological (Random data will sometimes go in the same direction)
51ae0a8 to
09fa321
Compare
jklymak
approved these changes
Sep 23, 2021
dstansby
reviewed
Sep 24, 2021
Member
dstansby
left a comment
There was a problem hiding this comment.
I've had a look over and it looks good - there's one change I don't understand at all though (left a comment) so I'm not personally comfortable approving yet.
| rendererAA(), | ||
| rendererBin(), | ||
| theRasterizer(8192), | ||
| theRasterizer(32768), |
Member
There was a problem hiding this comment.
What's the meaning of this change?
Member
There was a problem hiding this comment.
And does it need documenting in an API change note?
Member
There was a problem hiding this comment.
That is:
- makes the upper limit higher so it will be hit less often
QuLogic
approved these changes
Sep 25, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 25, 2021
QuLogic
added a commit
that referenced
this pull request
Sep 25, 2021
…343-on-v3.5.x Backport PR #19343 on branch v3.5.x (Enh improve agg chunks error)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
…unks_error Enh improve agg chunks error
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Enh improve agg chunks error
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This does 2 important things:
and 2 less important things:
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).