DOC: fix an overlooked docs change from #19153#19433
DOC: fix an overlooked docs change from #19153#19433lpsinger wants to merge 1 commit intomatplotlib:masterfrom
Conversation
dstansby
left a comment
There was a problem hiding this comment.
We can't just get rid of these docs without deprecating the behaviour it documents (if indeed we do want to change the behaviour, which I'm not sure we do in this case), in particular
Meanwhile, if you do not want this behavior (i.e., you want to force the creation of a new subplot), you must use a unique set of args and kwargs.
|
I'm very concerned about this change, even if it was to go through a deprecation phase. As indicated in #19432 I don't understand why one would ever want the same axes to be returned if the projection and kwargs are different? |
|
I don't think I can dismiss my review, but if another maintainer wants to then go ahead. Apologies for jumping the gun on lots of this discussion, that has clearly been discussed more thoroughly on a dev call. I've tagged this as release critical so we don't forget it either way. |
|
Closing in favor of #19438. |
PR Summary
Fix an overlooked docs change from #19153, noted by @dstansby in #19432.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).