Always create a new subplot in plt.subplot()#19434
Closed
dstansby wants to merge 2 commits intomatplotlib:masterfrom
Closed
Always create a new subplot in plt.subplot()#19434dstansby wants to merge 2 commits intomatplotlib:masterfrom
dstansby wants to merge 2 commits intomatplotlib:masterfrom
Conversation
Member
Author
|
Woops, looks like I missed #18978 (comment), ie. should return the same axes, so this is going to need a bit more thought. |
Contributor
|
Can't the behavior be that the same axes are returned assuming no projections/kwargs are present, and otherwise new axes are returned? |
Member
Author
|
Yeah, I think that's what should happen - currently working on it. |
Contributor
|
@dstansby an alternative is to do as suggested in #18978 (comment) but then a warning does need to be raised as opposed to the current silent behavior. I'm not a fan of the axes reuse but if there is consensus about keeping the new behavior a warning has to be emitted (not just deprecation to be clear) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19432.
The behaviour before this patch was to return an existing
Axesif it had the same subplot-spec, regardless of**kwargs. This changes that to always create a newAxes, which is what is documented and expected from the deprecation.