Fix interaction between make_keyword_only and pyplot generation.#20686
Merged
timhoffm merged 1 commit intomatplotlib:masterfrom Jul 25, 2021
Merged
Fix interaction between make_keyword_only and pyplot generation.#20686timhoffm merged 1 commit intomatplotlib:masterfrom
timhoffm merged 1 commit intomatplotlib:masterfrom
Conversation
2271b49 to
ff0a938
Compare
No independent test (because mocking boilerplate.py is too hard), but note that the signature change on imshow works.
jklymak
approved these changes
Jul 21, 2021
Member
jklymak
left a comment
There was a problem hiding this comment.
This is all a little bit magical to me, but seems correct, and it passes the tests...
timhoffm
approved these changes
Jul 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No independent test (because mocking boilerplate.py is too hard), but
note that the signature change on imshow works.
Closes #20684.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).