Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}.#21141
Merged
timhoffm merged 1 commit intomatplotlib:masterfrom Sep 22, 2021
Merged
Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}.#21141timhoffm merged 1 commit intomatplotlib:masterfrom
timhoffm merged 1 commit intomatplotlib:masterfrom
Conversation
jklymak
approved these changes
Sep 21, 2021
Member
jklymak
left a comment
There was a problem hiding this comment.
I agree that this is the pattern we use most other places...
The docstring must be set (which we do using docstring.dedent_interpd) before the decoration with _preprocess_data(). While we're at it, replace kw by kwargs in quiver/barbs.
Contributor
Author
|
While I was at it, I also replaced |
timhoffm
approved these changes
Sep 22, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 22, 2021
…ation for quiver&contour{,f}.
jklymak
added a commit
that referenced
this pull request
Sep 22, 2021
…141-on-v3.5.x Backport PR #21141 on branch v3.5.x (Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}.)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}.
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docstring must be set (which we do using docstring.dedent_interpd)
before the decoration with _preprocess_data().
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).