Factor common parts of saving to different formats using pillow.#21376
Merged
story645 merged 1 commit intomatplotlib:masterfrom Oct 20, 2021
Merged
Factor common parts of saving to different formats using pillow.#21376story645 merged 1 commit intomatplotlib:masterfrom
story645 merged 1 commit intomatplotlib:masterfrom
Conversation
We don't need to drop the alpha channel for jpeg anymore as imsave handles that. In imsave, also clarify that `sm` is not going to be used in the already-usable-rgba case. Also, spliting out pil_kwargs under "other parameters" seems overkill for an effectively internal method (`savefig` is the user-facing API).
QuLogic
approved these changes
Oct 19, 2021
story645
approved these changes
Oct 19, 2021
story645
approved these changes
Oct 19, 2021
| dpi=self.figure.dpi, metadata=metadata, pil_kwargs=pil_kwargs) | ||
|
|
||
| @_check_savefig_extra_args | ||
| @_api.delete_parameter("3.5", "args") |
Member
There was a problem hiding this comment.
I can't follow if since is supposed to be the last version that has the parameter or first version without it
https://matplotlib.org/stable/_modules/matplotlib/_api/deprecation.html#delete_parameter
Contributor
Author
There was a problem hiding this comment.
No, since is the version where the deprecation was introduced (as for _api.deprecated); args is getting deprecated in 3.5.
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Factor common parts of saving to different formats using pillow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to drop the alpha channel for jpeg anymore as imsave
handles that.
In imsave, also clarify that
smis not going to be used in thealready-usable-rgba case.
Also, spliting out pil_kwargs under "other parameters" seems overkill
for an effectively internal method (
savefigis the user-facing API).Followup to #21274.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).