MNT: Set CapStyle member names automatically#22054
Merged
timhoffm merged 1 commit intomatplotlib:mainfrom Jan 2, 2022
Merged
Conversation
This was certainly overlooked in matplotlib#18544, otherwise it would make no sense to derive CapStyle from _AutoStringNameEnum.
Contributor
Author
|
Github seems to have a problem with setting up reviewdog. What should I do in such a case - just force push once more? |
Member
|
Is this technically an API change if users are accessing and using these attributes? Can we set them to enums with their previous string values so it's less API breaking? |
Contributor
Author
No, absolutely nothing changes - using |
anntzer
approved these changes
Jan 2, 2022
timhoffm
approved these changes
Jan 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This was certainly overlooked in #18544, otherwise it would make no sense to derive
CapStylefrom_AutoStringNameEnum.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).