Deprecated afm, fontconfig_pattern, and type1font#22133
Deprecated afm, fontconfig_pattern, and type1font#22133jklymak merged 2 commits intomatplotlib:mainfrom
afm, fontconfig_pattern, and type1font#22133Conversation
392b49d to
7ed5b69
Compare
type1fontafm, fontconfig_pattern, and type1font
|
How should one deal with these issues: Should one change the previous links to point to the new one? Reformat them to not be a link? Import the required classes/functions explicitly in the to-be-removed file? Especially: there is a PR #20715 that changes the now deprecated methods/classes. Should this be dealt with in a special way? Since it is now deprecated/private. |
7ed5b69 to
045121b
Compare
|
Please change the links in API changes to code literals using fully qualified names, e.g. to The API changes are historic documents for that point in time and we should not change their meaning. We can't reference with links in the current docs so the best option is literals. This is also true for the unreleased Concerning the first one, change |
It is only used (in the matplotlib codebase) in For consistency, one may also consider making |
08c4ed7 to
fd6b5b9
Compare
There was a problem hiding this comment.
Please switch to the two-commit solution as described in #22134 (review) to preserve history here as well.
fd6b5b9 to
406cd41
Compare
406cd41 to
1885e46
Compare
|
Imports are slightly improved here as well. |
PR Summary
Related to #16181.
Will update with release notes once the tests pass (and I get a PR-number...)
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).