Conversation
d0eda86 to
7c6ac68
Compare
lib/matplotlib/_mathtext.py
Outdated
| return [hlist] | ||
|
|
||
| def text(self, s, loc, toks): | ||
| self.pop_state() |
There was a problem hiding this comment.
This won't work with something like r"$\mathbf{\text{hello, world!}}$" (popping out of the mathbf puts you in italic mode, and setting back to italic at exit isn't correct either; instead I think you just need to push a new state for the \text.
There was a problem hiding this comment.
Ahh, OK! I'll look into the state things. Almost looked a bit too easy to solve it...
|
I can't repro the kerning issue? Usually you can try blowing up text size (e.g. fontsize=42) to make it easier to check them; otherwise it may just be pixellation. One major comment, but otherwise the approach looks good to me. (Just needs a test as well.) |
7c6ac68 to
f31b488
Compare
|
This is updated (although I only pushed, not commented), if you have time @anntzer ... |
|
Just one minor point left, I think. |
f31b488 to
f55733e
Compare

PR Summary
Closes #18520
gives

However, the kerning is still from math, see
where the spacing between the e and the r in where differs.
However, it is not the case for e.g.
r"where $\text{where}$"so not really clear to me why and where this happens.Again, a bit doubtful (see #22171) if I can generate correct test images, so tests must be added.
It is not really clear how things will work with special symbols etc. Right now
\{,\}and\$can be dealt with, but one can probably break it if one tries (as for LaTeX itself).PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).