Document what pyplot expects from a backend.#24218
Merged
timhoffm merged 1 commit intomatplotlib:mainfrom Nov 21, 2022
Merged
Conversation
3d1710a to
a187b77
Compare
timhoffm
reviewed
Nov 13, 2022
Member
timhoffm
left a comment
There was a problem hiding this comment.
General note: You use parentheses for additional comments a lot. I suggest you try and reduce their use.
a187b77 to
9e960db
Compare
Contributor
Author
|
Thanks for the review. I've addressed all points except the last one, which I'm not really sure of how to handle and would suggest deferring. |
9e960db to
ac43f88
Compare
timhoffm
approved these changes
Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
(split out of #23101 to make that easier to go in first; goes on top of it.)
Closes #12324.
Now ready to go.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).