Allow polar scales where zero is not in valid interval#24763
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Dec 31, 2022
Merged
Allow polar scales where zero is not in valid interval#24763QuLogic merged 1 commit intomatplotlib:mainfrom
QuLogic merged 1 commit intomatplotlib:mainfrom
Conversation
3110c21 to
4507ae5
Compare
oscargus
approved these changes
Dec 27, 2022
6 tasks
QuLogic
approved these changes
Dec 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This allows scales to be set on polar Axes where 0 is not in the valid scale limits (e.g. a log scale falls into this category). Because there is some special casing in polar radial view limits that tries to include zero all the time, I didn't want to break this, so instead I've gone for the most general check of running the interval [0, 1] through the scale's
limit_range_for_scalemethod, and checking if a 0 comes out. If it doesn't, the deafult behaviour of the locator is used to set the view limits and nonsingular values.Goes part way to fixing #24383
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst