Replace usage of WenQuanYi Zen Hei by Noto Sans CJK#25726
Merged
QuLogic merged 5 commits intomatplotlib:mainfrom May 8, 2023
Sigma-Verma:main
Merged
Replace usage of WenQuanYi Zen Hei by Noto Sans CJK#25726QuLogic merged 5 commits intomatplotlib:mainfrom Sigma-Verma:main
QuLogic merged 5 commits intomatplotlib:mainfrom
Sigma-Verma:main
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
tacaswell
reviewed
Apr 20, 2023
tacaswell
reviewed
Apr 20, 2023
QuLogic
reviewed
Apr 20, 2023
QuLogic
approved these changes
May 8, 2023
Member
|
Thanks @Sigma-Verma! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR replaces usage of WenQuanYi Zen Hei with the Noto Sans CJK font, which is already used in other examples and still available on Homebrew. This provides a more convenient and consistent experience for macOS users. The changes were made to the relevant examples in the docs/galleries, and the documentation was updated to reflect the font change.
PR Checklist
Documentation and Tests
pytestpasses)