[TYP] Reduce stubtest ignores#25844
Merged
timhoffm merged 1 commit intomatplotlib:mainfrom May 23, 2023
Merged
Conversation
Broadly makes the type hints more reflective of runtime behavior, though does incur some type:ignore comments because of sub/superclass interactions
oscargus
approved these changes
May 23, 2023
timhoffm
approved these changes
May 23, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Broadly makes the type hints more reflective of runtime behavior, though does incur some type:ignore comments because of sub/superclass interactions
In particular, mypy does not approve of making parameters to methods mandatory for subclasses (it is fine with adding optional params, just not making valid superclass calls invalid).
Nor does it approve of removing even an optional param (for the same reason).
Helper
_pathfunctions which are undocumented are no longer exported in thetransformsnamespace.Some additional comments added regarding corner cases of typing/explaining new ignores
PR checklist